MID: fixed Digits check result in case of noisy boards #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the presence of noisy boards, the result of the check on the empty boards was incorrectly ignored, leading in some cases to a Medium quality even with a large number of empty boards being present. The fix aggregates the qualities from the bad boards and empty boards checks, and also displays messages from both chekers in case they both detect problems.
aferrero2707
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
Contributor
Author
|
@ValerieRamillien @dstocco this is the fix to the MID digits checker that we discussed few days ago. |
knopers8
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the presence of noisy boards, the result of the check on the empty boards was incorrectly ignored, leading in some cases to a Medium quality even with a large number of empty boards being present.
The fix aggregates the qualities from the bad boards and empty boards checks, and also displays messages from both checkers in case they both detect problems.
Here is an example of output from the current code (wrong Medium quality) and new code (correct Bad quality):
CURRENT
NEW
